Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add field constraint in lockfile.json #202

Open
monperrus opened this issue May 10, 2023 · 2 comments
Open

add field constraint in lockfile.json #202

monperrus opened this issue May 10, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@monperrus
Copy link
Contributor

constraint would contain the version ranges

@monperrus
Copy link
Contributor Author

maybe constraint should be constraints (plural) and store an array

@MartinWitt
Copy link
Contributor

We have now the original maven version constraint for every dependency. Maven calls this: VersionRange. Sadly this a bit verbose. See

"versionRange": {
        "recommendedVersion": {
          "majorVersion": 5,
          "minorVersion": 9,
          "incrementalVersion": 2,
          "comparable": {
            "value": "5.9.2",
            "items": [
              {
                "value": 5
              },
              {
                "value": 9
              },
              {
                "value": 2
              }
            ]
          }
        },
        "restrictions": []
      }

I would keep it in this format for now and later talk about usability improvements. In this current format we can use the maven version range tooling and don't have to write it ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants