Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User service get user profile remove courses sessions #721 #747

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

csehatt741
Copy link

Resolves #721

What changes did you make and why did you make them?

  • removed loading user courses and sessions in UserService.getUserProfile to avoid pulling unnecessary data in user profile requests
  • removed redundant GetUserDto.courses property, as now it is never populated
  • removed redundant AuthService registration to clean up UserModule definition, as AuthService is exported by the global AuthModule

Did you run tests? Share screenshot of results:

image

@csehatt741 csehatt741 force-pushed the csehatt741/userService-getUserProfile-remove-courses-sessions-#721 branch from 1fa369c to 20f5821 Compare January 8, 2025 05:51
@csehatt741 csehatt741 changed the title Csehatt741/user service get user profile remove courses sessions #721 csehatt741/user service get user profile remove courses sessions #721 Jan 8, 2025
@csehatt741 csehatt741 changed the title csehatt741/user service get user profile remove courses sessions #721 User service get user profile remove courses sessions #721 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove courses and sessions from userService.getUserProfile and refactor module imports
1 participant