Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner Admin First Login Fails #736

Open
csehatt741 opened this issue Dec 26, 2024 · 2 comments
Open

Partner Admin First Login Fails #736

csehatt741 opened this issue Dec 26, 2024 · 2 comments
Assignees
Labels
bug Something isn't working question/suggestion Further information is requested

Comments

@csehatt741
Copy link

Description
When a newly created Partner Admin tries to log in the first time it fails, as user.lastActiveAt is null:

Logging in the second time succeeds, as user.lastActiveAt is not null anymore.

To Reproduce
Steps to reproduce the behavior:

  1. Log in with a Super Admin
  2. Go to 'admin/dashboard' and create a new Partner Admin
  3. Log out
  4. Go to 'auth/login' and click on 'Reset here' to reset password
  5. Enter the email of the newly created Partner Admin and click on 'Reset Password'
  6. Open the reset password link sent to the email of the Partner Admin
  7. Set the new password
  8. Go to 'auth/login' and try to log in with the Partner Admin
  9. See error There was an error retrieving your account.

Expected behavior: User should be logged in

On the backend side there is an exception thrown: TypeError: Cannot read properties of null (reading 'getDate')

/app/src/user/user.service.ts:250
      updateUserDto.lastActiveAt.getDate() === user.lastActiveAt.getDate()
                                                                 ^
TypeError: Cannot read properties of null (reading 'getDate')
    at UserService.updateUser (/app/src/user/user.service.ts:250:66)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Desktop

  • OS: Windows 11
  • Browser: Edge
  • Version: 131.0.2903.112
@kyleecodes kyleecodes added bug Something isn't working question/suggestion Further information is requested labels Jan 4, 2025
@kyleecodes kyleecodes added this to the 04. Maintenance and Testing milestone Jan 4, 2025
@kyleecodes kyleecodes self-assigned this Jan 4, 2025
Copy link

github-actions bot commented Jan 4, 2025

Thank you @kyleecodes you have been assigned this issue!
Please follow the directions in our Contributing Guide. We look forward to reviewing your pull request. ✨


Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you!
Learn more about our impact and sign-up for our volunteer programsto join our mission!. 🌸

@kyleecodes
Copy link
Member

Hi @csehatt741, thank you for this thorough bug report!
Looking into this, here is the relevant issue for reference: #717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question/suggestion Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants