Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Functionality to get similar books #5

Closed
adeen-s opened this issue May 29, 2018 · 12 comments
Closed

Functionality to get similar books #5

adeen-s opened this issue May 29, 2018 · 12 comments
Assignees
Labels
must-have This feature is an essential part of the MVP New Feature Adding or requesting a new feature

Comments

@adeen-s
Copy link
Contributor

adeen-s commented May 29, 2018

Please write the User story for this feature
As a user I want similar books for a book recommended to me so that I can read them in the future

Describe the solution you'd like
A clear and concise description of what you want to happen.
Return similar books based on a book

@adeen-s adeen-s added New Feature Adding or requesting a new feature must-have This feature is an essential part of the MVP labels May 29, 2018
@adeen-s
Copy link
Contributor Author

adeen-s commented May 30, 2018

Assigning this to me.

@adeen-s adeen-s assigned adeen-s and Shivam60 and unassigned adeen-s and Shivam60 May 30, 2018
@adeen-s
Copy link
Contributor Author

adeen-s commented May 31, 2018

List of subtasks for reference:

  • Use Tastedive.com API to get similar books
  • Implement firebase cloud function to get search query and return JSON data Find some other workaround since Firebase does not allow outbound requests on the free tier.. This is to protect the API key.
  • Parse JSON data to get list of books based on similarity.
  • Display the List of books in the desired format of the website.

@adeen-s
Copy link
Contributor Author

adeen-s commented May 31, 2018

Interacting with the API:

@adeen-s
Copy link
Contributor Author

adeen-s commented Jun 11, 2018

Current Status:

  • Built the functionality using vanilla JS

Todo now:

  • Make us of vue for the same functionality

@Shivam60
Copy link
Contributor

so i have done it in vanila JS. I return a list of 20 similar books from given book name(i assume book name is correct)
Should I do it in vue now?

@adeen-s
Copy link
Contributor Author

adeen-s commented Jun 12, 2018

@Shivam60 You should be working on #7 , I got this one.

@adeen-s
Copy link
Contributor Author

adeen-s commented Jun 12, 2018

@ahegazy I need some help here. I have done the part where I now get the list of similar books. I have appended the list as an object to the similar_books object of ResultsObj. and I can see the output in concole.log().
When I try to display it in book.vue, nothing is shown.

screenshot from 2018-06-12 15-45-54

@ahegazy
Copy link
Contributor

ahegazy commented Jun 12, 2018

@adeen-s can I see the code
Can you push it to your fork?

@adeen-s
Copy link
Contributor Author

adeen-s commented Jun 12, 2018

It's on my fork.

@ahegazy
Copy link
Contributor

ahegazy commented Jun 12, 2018

A PR would be good :D

@adeen-s
Copy link
Contributor Author

adeen-s commented Jun 12, 2018

I don't want to make an incomplete PR to this repo. I will do it if you want me to, but I do not want to.

@ahegazy
Copy link
Contributor

ahegazy commented Jun 12, 2018

it would be easier to see the difference + we can edit it as we want and it wouldn't affect the main repo ..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
must-have This feature is an essential part of the MVP New Feature Adding or requesting a new feature
Projects
None yet
Development

No branches or pull requests

3 participants