Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures due to API changes in openmmtools #1299

Closed
mattwthompson opened this issue Apr 13, 2023 · 3 comments
Closed

Failures due to API changes in openmmtools #1299

mattwthompson opened this issue Apr 13, 2023 · 3 comments
Milestone

Comments

@mattwthompson
Copy link

See for example: https://github.com/openforcefield/openff-evaluator/actions/runs/4685350308/jobs/8302368552?pr=509

It looks like the import path changed in choderalab/openmmtools#669 without complete re-exporting of the old paths

@ijpulidos
Copy link

@mattwthompson that's correct, that changed upstream, a quick fix here is doing the ugly from openmmtools.utils.utils import find_subclass. But maybe we just want the complete re-export of all the elements in utils.pyupstream.

@mattwthompson
Copy link
Author

Yup that's what I did - re-exporting everything again might be a good idea, though. It looks like that was attempted (mostly successfully) in that PR.

I'm mostly raising this because it breaks (some part of) Yank, which I can't patch and fire off a release of

@ijpulidos
Copy link

upstream choderalab/openmmtools#698 was already merged and there's a new 0.23 release of openmmtools in conda-forge. This should be solved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants