Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency #33

Open
coissac opened this issue Feb 14, 2021 · 4 comments
Open

Missing dependency #33

coissac opened this issue Feb 14, 2021 · 4 comments

Comments

@coissac
Copy link

coissac commented Feb 14, 2021

Hi,

In version lookr_0.4.2 there is a missing dependency on systemfonts

Cheers

@choonghyunryu
Copy link
Owner

@coissac,

Thanks your recommand.

The dlookr package imports the extrafont package. Does not use the systemfonts package. Please explain why you think the systemfonts package is missing from the dependency.

Best Regards,
Ryu

@coissac
Copy link
Author

coissac commented Feb 15, 2021

When I tryed to install it on a mac

platform       x86_64-apple-darwin17.0     
arch           x86_64                      
os             darwin17.0                  
system         x86_64, darwin17.0          
status                                     
major          4                           
minor          0.1                         
year           2020                        
month          06                          
day            06                          
svn rev        78648                       
language       R                           
version.string R version 4.0.1 (2020-06-06)
nickname       See Things Now             

I got an installation error because of that missing package.
I installed systemfonts, then install again dlookr, and it worked.
Therefore, I suppose that a hidden dependency must exist ;-)

Cheers

@coissac
Copy link
Author

coissac commented Feb 15, 2021

Looking into the dlookr dependencies recursively you can find systemfonts
and extrafont

> packrat:::recursivePackageDependencies("dlookr",lib.loc = .libPaths()[1])
  [1] "BH"            "Formula"       "Hmisc"         "MASS"          "Matrix"       
  [6] "MatrixModels"  "R6"            "RColorBrewer"  "RcmdrMisc"     "Rcpp"         
 [11] "RcppArmadillo" "RcppEigen"     "Rttf2pt1"      "SparseM"       "abind"        
 [16] "askpass"       "assertthat"    "backports"     "base64enc"     "boot"         
 [21] "brio"          "broom"         "callr"         "car"           "carData"      
 [26] "cellranger"    "checkmate"     "class"         "cli"           "clipr"        
 [31] "cluster"       "colorspace"    "conquer"       "corrplot"      "cpp11"        
 [36] "crayon"        "curl"          "data.table"    "desc"          "diffobj"      
 [41] "digest"        "dplyr"         "e1071"         "ellipsis"      "evaluate"     
 [46] "extrafont"     "extrafontdb"   "fansi"         "farver"        "forcats"      
 [51] "foreign"       "gdtools"       "generics"      "ggplot2"       "glue"         
 [56] "gridExtra"     "gtable"        "haven"         "highr"         "hms"          
 [61] "hrbrthemes"    "htmlTable"     "htmltools"     "htmlwidgets"   "httr"         
 [66] "inum"          "isoband"       "jpeg"          "jsonlite"      "kableExtra"   
 [71] "knitr"         "labeling"      "lattice"       "latticeExtra"  "libcoin"      
 [76] "lifecycle"     "lme4"          "magrittr"      "maptools"      "markdown"     
 [81] "matrixStats"   "mgcv"          "mice"          "mime"          "minqa"        
 [86] "munsell"       "mvtnorm"       "nlme"          "nloptr"        "nnet"         
 [91] "nortest"       "openssl"       "openxlsx"      "partykit"      "pbkrtest"     
 [96] "pillar"        "pkgbuild"      "pkgconfig"     "pkgload"       "png"          
[101] "praise"        "prettydoc"     "prettyunits"   "processx"      "progress"     
[106] "ps"            "purrr"         "quantreg"      "readr"         "readstata13"  
[111] "readxl"        "rematch"       "rematch2"      "rio"           "rlang"        
[116] "rmarkdown"     "rpart"         "rprojroot"     "rstudioapi"    "rvest"        
[121] "sandwich"      "scales"        "selectr"       "sp"            "statmod"      
[126] "stringi"       "stringr"       "survival"      "sys"           "systemfonts"  
[131] "testthat"      "tibble"        "tidyr"         "tidyselect"    "tinytex"      
[136] "utf8"          "vctrs"         "viridis"       "viridisLite"   "waldo"        
[141] "webshot"       "withr"         "xfun"          "xml2"          "yaml"         
[146] "zip"           "zoo" 

@choonghyunryu
Copy link
Owner

choonghyunryu commented Feb 15, 2021

@coissac,

Thanks for your advice.

I changed the dependency of hrbrthemes from hrbrthemes to hrbrthemes(>= 0.8.0).

The hrbrthemes package imported the gdtools package from version 0.6.0. And the gdtools package imports the systemfonts package. hrbrthemes(>=0.6.0) -> gdtools -> systemfonts

It is probably an error that occurs in an environment where the hrbrthemes package is installed before version 0.6.0. So, I modified the dependency of hrbrthemes.

> packrat:::getPackageDependencies("hrbrthemes", lib.loc = .libPaths()[1])
[1] "extrafont" "gdtools" "ggplot2" "htmltools" "knitr" "magrittr" "rmarkdown" "scales"
> packrat:::getPackageDependencies("gdtools", lib.loc = .libPaths()[1])
[1] "Rcpp" "systemfonts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants