Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interesting performance bottleneck with large list #1543

Open
Bouke opened this issue Sep 19, 2022 · 2 comments
Open

Interesting performance bottleneck with large list #1543

Bouke opened this issue Sep 19, 2022 · 2 comments

Comments

@Bouke
Copy link
Contributor

Bouke commented Sep 19, 2022

An API endpoint unexpectedly returned a very large set of items (~45k). The load happens through Ember Data and the processing went fine. However the page became unresponsive and investigation showed an unexpected bottleneck: getBoundingClientRect. See also this trace in Safari:

image

While I agree that listing 45k items isn't a practical use-case, I do think that it shouldn't cause the page to become unresponsive. This call is originating from setupMutationObserver. Maybe a debounce of some sorts would help?

This is on EPS 4.1.2, EBD 3.0.13 and Ember 3.25.1.

@derrabauke
Copy link
Contributor

We implemented / copied an approach utilizing VerticalCollection of the "@html-next/vertical-collection" package. Works quite well with large lists. Hope this inspires ;)

@betocantu93
Copy link
Contributor

We also did that in ember-eui/combo-box

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants