Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When in Japanese input, 'enter' should not immediately send the message #2103

Open
dvcrn opened this issue Dec 19, 2024 · 2 comments
Open

When in Japanese input, 'enter' should not immediately send the message #2103

dvcrn opened this issue Dec 19, 2024 · 2 comments

Comments

@dvcrn
Copy link

dvcrn commented Dec 19, 2024

Describe the bug

In Japanese IME, you typically type text, then hit enter to "commit" the correct Kanji. For example, if I type テスト then it will be underlined until I hit 'enter', in effect confirming that I've finished writing and picked the correct Kanji/characters

Cinny binds to enter, so even though I am not done typing and only committed a word, as soon as I hit enter, Cinny sends the message

It's a very common problem when using onkeyup as listener, eg: https://stackoverflow.com/questions/46812908/enter-keyup-event-in-japanese-input

Reproduction

No response

Expected behavior

No response

Platform and versions

macOS Desktop 4.2.3, macOS 15.2

Additional context

No response

@kfiven
Copy link
Collaborator

kfiven commented Dec 19, 2024

There's an option to change the behavior of Enter in settings, have you tried that?

@dvcrn
Copy link
Author

dvcrn commented Dec 20, 2024

Yes that works, but it's not the expected behavior. Hitting enter when in Japanese (or other asian) IME should not trigger sending of a message, since it will send an incomplete sentence/word

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants