Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check output of basic ScubaGear commands #1490

Open
1 task
james-garriss opened this issue Dec 24, 2024 · 0 comments
Open
1 task

Check output of basic ScubaGear commands #1490

james-garriss opened this issue Dec 24, 2024 · 0 comments
Assignees
Labels
enhancement This issue or pull request will add new or improve existing functionality Testing This issue or task involves testing the automation tool function
Milestone

Comments

@james-garriss
Copy link
Collaborator

💡 Summary

Running ScubaGear involves 3 basic commands that are documented in our readme:

  • Install-Module -Name ScubaGear
  • Initialize-SCuBA
  • Invoke-SCuBA -Version

Occasionally these have thrown non-terminating, unexpected warnings or errors that indicated an underlying problem existed. There are not any tests to catch these, thus SG has had problems at release time that we didn't know about.

Motivation and context

Code should be tested before release to catch unexpected issues so that we don't release a buggy version of SG.

Implementation notes

  • Create a workflow triggered on workflow_call.
  • Run these 3 commands and whitelist their outputs
  • Fail if anything else happens
  • Call this workflow from one or more other workflows

Acceptance criteria

How do we know when this work is done?

  • Unexpected problems are detected.
@james-garriss james-garriss added enhancement This issue or pull request will add new or improve existing functionality Testing This issue or task involves testing the automation tool function labels Dec 24, 2024
@james-garriss james-garriss added this to the Lionfish milestone Dec 24, 2024
@james-garriss james-garriss self-assigned this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality Testing This issue or task involves testing the automation tool function
Projects
None yet
Development

No branches or pull requests

1 participant