Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several policies are marked and counted as grey and manual checks when results are "N/A" and marked with a criticality of "Not-implemented" due to specific conditions #1498

Open
ahuynhMITRE opened this issue Jan 9, 2025 · 0 comments
Labels
bug This issue or pull request addresses broken functionality

Comments

@ahuynhMITRE
Copy link
Collaborator

ahuynhMITRE commented Jan 9, 2025

🐛 Summary

What's wrong? Please be specific.
MS.AAD.3.5v1, MS.SHAREPOINT.1.3v1, MS.SHAREPOINT.1.4v1, MS.SHAREPOINT.3.1v1, MS.SHAREPOINT.3.2v1, and MS.SHAREPOINT.3.3v1 in the html reports are highlighted as grey and counted in the manual checks. This cause confusion for the user/reader of the html report as these policies are represented as "manual checks".

To reproduce

When running ScubaGear:

Summery Report "manual check" counts:
Image

  • MS.AAD.3.5v1; "Shall/Not-Implemented" will be shown in the results column of the report when "Managed Migration" feature not set to "Migration Complete"
Image
  • MS.SHAREPOINT.1.3v1, MS.SHAREPOINT.1.4v1, MS.SHAREPOINT.3.1v1, MS.SHAREPOINT.3.2v1, and MS.SHAREPOINT.3.3v1; "Shall/Not-Implemented" will be shown in the results column of the report when "External Sharing" is set to "Only People In Your Organization"
Image

Expected behavior

When the policies mentioned above result in "N/A" for criticality labeled as "Shall/Not-Implemented" they should not be counted as "manual checks" in the summary report and not highlighted as grey to match the other "manual checks"

@ahuynhMITRE ahuynhMITRE added the bug This issue or pull request addresses broken functionality label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

No branches or pull requests

1 participant