Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading mp3 does not work #41

Open
gitfortat opened this issue Aug 24, 2016 · 0 comments
Open

Downloading mp3 does not work #41

gitfortat opened this issue Aug 24, 2016 · 0 comments

Comments

@gitfortat
Copy link

When I try to download an mp3 (right-click) I get the following error (lines do not match with original version, since I made another commit, but this is unimportant):

Traceback (most recent call last):
File "/usr/lib/python3.5/site-packages/ldoce5viewer/qtgui/main.py", line 557, in finished
callback(reply.readAll())
File "/usr/lib/python3.5/site-packages/ldoce5viewer/qtgui/main.py", line 569, in showSaveDialog
file.write(data)
TypeError: write() argument must be str, not QByteArray

To fix it I changed the file mode to binary ("wb" instead of "w"): 08b27d8

Are the mp3 files not always in binary format? I am wondering why the default file mode seems to work for some. Are there different versions of the actual ldoce5 dictionary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant