Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 'aws-portworx' prefix in variables.tf in 210-aws-portworx-storage #212

Open
gowdhaman-j opened this issue Sep 12, 2022 · 1 comment
Assignees

Comments

@gowdhaman-j
Copy link
Contributor

For the below 2 variables, we need to remove 'aws-portworx' prefix.
variable "aws-portworx_portworx_spec" {
type = string
default = ""
}
variable "aws-portworx_portworx_spec_file" {
type = string
default = ""
}

If we do not remove , then I have to have variables specific for "aws" & "azure" in my terraform.tfvars. If we remove this then we can have 'portworx_spec' & 'portworx_spec_file' in terraform.tfvars.

@indirakalagara indirakalagara self-assigned this Sep 14, 2022
@indirakalagara
Copy link
Contributor

@gowdhaman-j FYI fixed this in the aws-portworx bom by adding variables for the portworx specs and aws creds. Now its in line with other portworx boms like azure, hence you should be able to use the same variable names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants