-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1 merge blueprint versions #2
Open
ppxl
wants to merge
19
commits into
develop
Choose a base branch
from
feature/1_merge_blueprint_verisons
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+361
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also fixes some minor typos, adds doc comments and moves some higher-level definitions into bpcore since v2 will probably make use of those as well.
ppxl
force-pushed
the
feature/1_merge_blueprint_verisons
branch
2 times, most recently
from
January 16, 2025 15:57
f1f68df
to
3ae1cdf
Compare
ppxl
force-pushed
the
feature/1_merge_blueprint_verisons
branch
from
January 17, 2025 06:41
3ae1cdf
to
5ce1784
Compare
This import was meant to compile as-is but some changes were necessary to make it compile without domain or kubernetes package references. Long story short, I needed to change a lot of things
This was changed during the extraction and was most likely a mistake. The original code used string here.
This was changed during the extraction and was most likely a mistake. The original code used string here.
This was changed during the extraction and was most likely a mistake. The original code used string here.
Somehow these functions seem to be necessary by the blueprint operator's deep copy generator even though I do not see where I might have deleted it
In package names v1/v2/v${nonzerointeger} is reserved to identify module versions. This was not the case of the previous state but rather the version of the blueprint implementation. This commit removes this misnaming towards json to amend the situation above and also to put the focus on the format being worked on.
The kubernetes implementation Blueprint v2 was moved into its own library k8s-blueprint-lib because there would be even more changes with way more k8s resources and logic attached. These two functionalities should not mix different libraries and possibly attach to another's core entities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1 and implement a merged dogu/k8s command that is able to mirror mixed v1 and v2 blueprints