Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1 merge blueprint versions #2

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

ppxl
Copy link
Member

@ppxl ppxl commented Jan 16, 2025

Resolve #1 and implement a merged dogu/k8s command that is able to mirror mixed v1 and v2 blueprints

ppxl added 3 commits January 16, 2025 08:54
This commit also fixes some minor typos, adds doc comments
and moves some higher-level definitions into bpcore since
v2 will probably make use of those as well.
@ppxl ppxl added the enhancement New feature or request label Jan 16, 2025
@ppxl ppxl force-pushed the feature/1_merge_blueprint_verisons branch 2 times, most recently from f1f68df to 3ae1cdf Compare January 16, 2025 15:57
@ppxl ppxl force-pushed the feature/1_merge_blueprint_verisons branch from 3ae1cdf to 5ce1784 Compare January 17, 2025 06:41
ppxl added 13 commits January 17, 2025 16:17
This import was meant to compile as-is but some changes were necessary
to make it compile without domain or kubernetes package references. Long
story short, I needed to change a lot of things
This was changed during the extraction and was most likely a mistake.
The original code used string here.
This was changed during the extraction and was most likely a mistake.
The original code used string here.
This was changed during the extraction and was most likely a mistake.
The original code used string here.
Somehow these functions seem to be necessary by the blueprint operator's
deep copy generator even though I do not see where I might have deleted
it
In package names v1/v2/v${nonzerointeger} is reserved to identify module
versions. This was not the case of the previous state but rather the
version of the blueprint implementation.

This commit removes this misnaming towards json to amend the situation
above and also to put the focus on the format being worked on.
The kubernetes implementation Blueprint v2 was moved into its own
library k8s-blueprint-lib because there would be even more changes with
way more k8s resources and logic attached. These two functionalities
should not mix different libraries and possibly attach to another's core
entities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement this library
1 participant