Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix atom typing errors when using OPLS #17

Open
chrisjonesBSU opened this issue Nov 5, 2020 · 0 comments
Open

Fix atom typing errors when using OPLS #17

chrisjonesBSU opened this issue Nov 5, 2020 · 0 comments

Comments

@chrisjonesBSU
Copy link
Member

chrisjonesBSU commented Nov 5, 2020

PEEK:
gaff: Works
opls: Error

Exception: Parameters have not been assigned to all proper dihedrals. Total system dihedrals: 174, Parameterized dihedrals: 158. Note that if your system contains torsions of Ryckaert-Bellemans functional form, all of these torsions are processed as propers.

PEKK:
gaff: Works

opls: Error

Exception: Parameters have not been assigned to all proper dihedrals. Total system dihedrals: 180, Parameterized dihedrals: 154. Note that if your system contains torsions of Ryckaert-Bellemans functional form, all of these torsions are processed as propers.

So far, it looks like the errors are not being able to assign all of the dihedrals when using the opls forcefield.

If we pass assert_dihedral_params=False when using OPLS, then both PEEK and PEKK will work.

This fix won't require much within this repo, but rather with foyer. We could make a PR that adds missing dihedrals, but I'm not sure how long that would take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant