Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multip ping for ranges #114

Open
dreua opened this issue Nov 23, 2024 · 3 comments
Open

Multip ping for ranges #114

dreua opened this issue Nov 23, 2024 · 3 comments

Comments

@dreua
Copy link
Member

dreua commented Nov 23, 2024

Originally posted by @dark-spark in #113 (comment)

If I could add a request from a user point of view, multi ping is fantastic, but a common use case for me is pinging a series of ip addresses, if we could implement a way to ping an address and the following x amount of addresses I'd love that. For example 192.168.1.100 -n 5 would ping.100-.014

@dreua
Copy link
Member Author

dreua commented Nov 23, 2024

Please don't hijack other PRs for new requests on a different feature, we'll end up with big chaos if everyone does this 😉

For your use case I wonder if that could be done without any code on our side at all. Bash has this built in feature that expands ranges like foo{0..3} to foo0 foo1 foo2 foo3 iirc that should already work with the PR we have, could you try that?

@dark-spark
Copy link

Sorry about that. I will have a play with that and see how I go.

@mrbesen
Copy link
Contributor

mrbesen commented Dec 15, 2024

This sounds like an feature to look at after this thing is merged: #109
BTW @dreua i am waiting for an review there 😉

iirc that should already work with the PR we have, could you try that?

I don't think so. My MR requires you to write -h in front of every extra host. I guess we would need to adjust it in a way to accept any extra arguments as ping host. To work with bash brace expansion. But i guess it would be easy to write a little bash function to expand it correctly. Writing a ip net in CIDR notation like 192.168.1.0/28 would also be an interessting form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants