Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the occurrence of 404 Errors in the app #3184

Open
Tracked by #3172
Adal3n3 opened this issue Jan 6, 2025 · 1 comment
Open
Tracked by #3172

Reduce the occurrence of 404 Errors in the app #3184

Adal3n3 opened this issue Jan 6, 2025 · 1 comment
Milestone

Comments

@Adal3n3
Copy link

Adal3n3 commented Jan 6, 2025

The Problem

We know many customers encounter the 404 page in various ways, but the most common occurrences happen when the UI fails to load, times out, or users experience login issues. This GH issue focuses on improving the following flow:

User comes to codecov from PR > 404 > needs to login > has to navigate away to login > loses PR context.

This flow is particularly important to the product experience, as it frustrates users trying to access the app. View this issue to learn more about the pain points.

The Goal

  • reduce total # of 404s

Proposed next steps

  1. Investigate what are the specific reasons to trigger the 404 page from the flow? (PR > 404)
  2. Reduce the # of 404 occurs has a dependency on step 1.

(@Adal3n3 will need to polish this issue)
Investigation note:
If the page "fails to parse," we either display the 404 page or show nothing at all.

Image
Image

https://codecov.sentry.io/issues/6107136679/events/5d5c6474728b4dcfb3fd2a0f6003c05d/?project=5514400&referrer=replay-errors

This investigation failed to fetch (404) issue is to find out the following questions:

  1. What is the impact of the "failed to fetch" error from Sentry?
  2. How often are users encountering the 404 page?
  3. Are there particular patterns that trigger the 404 page most often?
  4. What are the specific reasons the UI fails to load or times out that cause the majority of "failed to fetch" and "failed to parse" errors?
  5. What types of login issues are causing users to encounter the 404 page?

Estimated investigation Timebox: 1 day

Dev Notes:

  • Look to consolidate "failed to fetch" issue types (maybe by request URL?)
  • Determine "real" number of users impacted and the impact states
    • i.e. Does a refresh fix 50%+ of users?
  • Long load time could be related to large timeout value / number of retries
    • What are these values and should we fail faster?
@Adal3n3 Adal3n3 changed the title "Failed to fetch" error (404 issue) "Failed to fetch" error (404) Jan 6, 2025
@Adal3n3 Adal3n3 changed the title "Failed to fetch" error (404) [Investigate] "Failed to fetch" error (404) Jan 6, 2025
@Adal3n3 Adal3n3 changed the title [Investigate] "Failed to fetch" error (404) Reduce the occurrence of 404 Errors in the app Jan 7, 2025
@Adal3n3 Adal3n3 added the epic this label is used to mark issues as epics label Jan 7, 2025
@Adal3n3 Adal3n3 added this to the Q1'25 milestone Jan 7, 2025
@Adal3n3 Adal3n3 removed the epic this label is used to mark issues as epics label Jan 7, 2025
@nicholas-codecov
Copy link

Look to consolidate "failed to fetch" issue types (maybe by request URL?)

A lot of these errors will be easier to track with the work being done migrating to rejectNetworkError so we can better track which specific data fetching services are failing and their frequencies via Sentry.

Long load time could be related to large timeout value / number of retries
What are these values and should we fail faster?

We retry three times per request, i don't believe we're timing out any requests from the API, there are a couple cases where there are looooooong requests but then succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants