Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to load all packages each times with providers enabled ? #556

Open
glickel opened this issue Jul 26, 2019 · 1 comment
Open

Comments

@glickel
Copy link
Contributor

glickel commented Jul 26, 2019

Hello,
On BuildCommand if we have a package/repository filter, we load all packages to dump them with the PackagesBuilder :

if ($packageSelection->hasFilterForPackages() || $packageSelection->hasRepositoryFilter()) {
    // in case of an active filter we need to load the dumped packages.json and merge the
    // updated packages in
    $oldPackages = $packageSelection->load();
    $packages += $oldPackages;
    ksort($packages);
}

$packagesBuilder = new PackagesBuilder($output, $outputDir, $config, $skipErrors);
$packagesBuilder->dump($packages);

Is it really needed if providers option is enabled ?
If no, I can create a pull request to change the code

@glickel glickel changed the title Do we need to load packages each times with providers enabled ? Do we need to load all packages each times with providers enabled ? Jul 26, 2019
@giem-git
Copy link

Hello,

I'm proposing a change here #650 that could fix your issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants