Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try using absolute position in parsers instead of relative #2500

Open
harendra-kumar opened this issue Aug 5, 2023 · 2 comments · May be fixed by #2861
Open

Try using absolute position in parsers instead of relative #2500

harendra-kumar opened this issue Aug 5, 2023 · 2 comments · May be fixed by #2861
Assignees
@adithyaov
Labels
api:breaking Incompatible with existing releases
Milestone
0.11.0

Comments

@harendra-kumar
Copy link
Member

harendra-kumar commented Aug 5, 2023 •
edited
Loading

That way we can pinpoint error locations. or maybe we can keep using the relative position in the parser, but keep track of the absolute offset in the parser driver.
@harendra-kumar harendra-kumar added this to the 0.10.0 milestone Aug 5, 2023
@harendra-kumar harendra-kumar modified the milestones: 0.10.0, 0.11.0 Jan 12, 2024
@harendra-kumar
Copy link
Member Author

In ParserK we will have to pass the absolute position around in the continuations. In Parser we can just maintain it in the driver. The position can include the byteOffset and lineCount (for Char/Byte streams only) up to the current chunk.

@harendra-kumar harendra-kumar added the api:breaking Incompatible with existing releases label Jul 14, 2024
@adithyaov
Copy link
Member

See #2861

@adithyaov adithyaov linked a pull request Oct 10, 2024 that will close this issue
Track the absolute position in the drivers of Parser #2861
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adithyaov adithyaov

Labels
api:breaking Incompatible with existing releases
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

Track the absolute position in the drivers of Parser composewell/streamly
2 participants
@harendra-kumar @adithyaov