Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download improvements #1007

Open
wolfv opened this issue Jan 2, 2025 · 0 comments
Open

Download improvements #1007

wolfv opened this issue Jan 2, 2025 · 0 comments
Labels
🚀 performance Performance related

Comments

@wolfv
Copy link
Contributor

wolfv commented Jan 2, 2025

We did a bunch of improvements to make linking files faster. There are some speedups to be had when downloading files as well:

I think we should download into a "spooled temporary file". Currently we are always downloading and immediately extracting the file. Extraction can be slow, which slows down the download as well. IMO we should do both as fast as possible, extracting and downloading.

We also use the default BufReader of bzip2 / zstd when decompressing. While this is perfectly fine for files loaded from disk, it might not be optimal for downloads. The default buffer size is 8 KB. E.g. uv is using 128KB buffer size instead. So I think increasing the buffer size might result in faster downloads & faster decompression as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 performance Performance related
Projects
None yet
Development

No branches or pull requests

2 participants