Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

[card] Deposit then immediate withdrawal bug #464

Closed
rhlsthrm opened this issue Oct 21, 2019 · 3 comments · Fixed by #642
Closed

[card] Deposit then immediate withdrawal bug #464

rhlsthrm opened this issue Oct 21, 2019 · 3 comments · Fixed by #642
Assignees
@ArjunBhuptani
Labels
Bug Something isn't working p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers.
Milestone
Core wallet integ...

Comments

@rhlsthrm
Copy link
Contributor

Reported by Bruno from Metamask. Steps to repro:

  • Deposit in card
  • Immediately withdraw after deposit completes (after the number shows up)

FYI, I could not reproduce this locally when I tried.
@rhlsthrm rhlsthrm added Bug Something isn't working p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers. labels Oct 21, 2019
@rhlsthrm rhlsthrm added this to the v2 DaiCard and WalletConnect milestone Oct 21, 2019
@LayneHaber
Copy link
Contributor

Going to prioritize #462 (which changes deposit fns), and come back to this afterwards to see if it is resolved or easier to repro

@ArjunBhuptani
Copy link
Member

Instead of hunting the bug, let's add an e2e test to check if this passes.

@LayneHaber
Copy link
Contributor

Fixed in #640 but still needs an e2e test

@ArjunBhuptani ArjunBhuptani self-assigned this Dec 13, 2019
@ArjunBhuptani ArjunBhuptani mentioned this issue Dec 13, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ArjunBhuptani ArjunBhuptani

Labels
Bug Something isn't working p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers.
Projects
None yet
Milestone
Core wallet integration featureset co...
Development

Successfully merging a pull request may close this issue.

Test deposit/withdraw a second time in cypress connext/indra
3 participants
@rhlsthrm @LayneHaber @ArjunBhuptani