Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Env variables apply a trim when saved #4734

Open
jesusantguerrero opened this issue Jan 4, 2025 · 2 comments
Open

[Bug]: Env variables apply a trim when saved #4734

jesusantguerrero opened this issue Jan 4, 2025 · 2 comments
Labels
🐛 Bug Reported issues that need to be reproduced by the team. 🔍 Triage Issues that need assessment and prioritization.

Comments

@jesusantguerrero
Copy link

Error Message and Logs

When storing Environment Variables the app applies a trim to the values, a leading space is an accepted and valid character for passwords for example.

Image

Image

It seems that they are trimmed at this line

$environment_variable = trim($environment_variable);

Steps to Reproduce

  1. Go to Environment Variables
  2. Add one that starts with a space
  3. You see that the initial space is removed

Example Repository URL

No response

Coolify Version

v4.0.0-beta.379

Are you using Coolify Cloud?

No (self-hosted)

Operating System and Version (self-hosted)

Ubuntu 22.04

Additional Information

No response

@jesusantguerrero jesusantguerrero added 🐛 Bug Reported issues that need to be reproduced by the team. 🔍 Triage Issues that need assessment and prioritization. labels Jan 4, 2025
@yashkolambekar
Copy link

It's not a bug, it's a feature

@jesusantguerrero
Copy link
Author

It's not a bug, it's a feature

No, it isn't. I think this functionality should replicate what a dev can do with a .env If a dev enters an space and is an error then is an layer 8. But a valid character shouldn't be deleted.

Vercel for example alert the dev that there's an space but don't trim

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Reported issues that need to be reproduced by the team. 🔍 Triage Issues that need assessment and prioritization.
Projects
None yet
Development

No branches or pull requests

2 participants