New Github style?

[fladd]

Hi there, very nice theme. Are there plans to update it to reflect Github's style as of 2020?

[cormacrelf]

Have they changed?

[luisdavim]

there's a new official dark mode is that what this is referring to?

[fladd]

there's a new official dark mode is that what this is referring to?

No that is not what I meant. I was talking about the current default Github style.

[luisdavim]

Did the colours on the light theme change?

[cormacrelf]

1. Don't think the light theme changed. If you're thinking "but gee they look different" try a build of vim and a terminal that supports set termguicolors.
2. The dark theme on GitHub.com was released yesterday ish, and I made my version long before they released theirs. I'm not going to change it because I like mine as it is.

If anyone wants to do a 2020 fork, go ahead (but rename the fork once you have so people can install both at the same time).

[fladd]

There have been changes in the light theme, yes. A while ago already.

[cormacrelf]

Well that's something specific I can comment on! If you're comparing a particular file between this scheme and GitHub.com, then almost any file will look at least a little different, and that has always been the case. I don't know that that counts as GitHub having changed. I make no claim that if you took a screenshot like this a year ago it would have looked identical. In any case, the goal is to use the GitHub colours and make a pleasing highlight, so I would absolutely have stopped there when trying to improve Python before. The colour palette hasn't changed that I know of, and that's what I was referring to above.

GitHub has always used different code highlighting from Vim, and therefore different syntax groups. It's possible their new highlighting does more with Python than it used to using a tree sitter backend, so I'd recommend trying using the Neovim tree sitter stuff to get more semantic highlights. If you want to improve the Python syntax, again I would welcome a PR!

[luisdavim]

looks like there's a fork to update some colours to the 2020 pallet: master...carlweis:master but that won't fix differences between highlighting groups....