Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app:slider_icon doesn't work when layout_height is set a lower value #168

Open
Mahir101 opened this issue Jan 22, 2022 · 1 comment
Open

Comments

@Mahir101
Copy link

Mahir101 commented Jan 22, 2022

Suppose this xml code,
<com.ncorti.slidetoact.SlideToActView
android:id="@+id/slider"
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:slider_locked="true"
app:slider_icon="@drawable/icon_24_24"
app:text="Slide Right" />

The custom slider icon is not working.

See this post for more: https://stackoverflow.com/questions/70812836/custom-icon-is-not-being-loaded-in-slidetoactview-from-slidetoact-dependency-fro

I figured out in your code that you don't handle vector images correctly.

@Mahir101 Mahir101 changed the title app:slider_icon doesn't work, the custom icon is not being loaded app:slider_icon doesn't work when layout_height is set a lower value, the custom icon is not being loaded Jan 24, 2022
@Mahir101 Mahir101 changed the title app:slider_icon doesn't work when layout_height is set a lower value, the custom icon is not being loaded app:slider_icon doesn't work when layout_height is set a lower value Jan 24, 2022
@cortinico
Copy link
Owner

I figured out in your code that you don't handle vector images correctly.

Please send a PR and provide a reproducer 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants