From adbd5c96c3d499340bdd985cef27eedfd70bc056 Mon Sep 17 00:00:00 2001 From: sangier <45793271+sangier@users.noreply.github.com> Date: Mon, 4 Nov 2024 15:41:30 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Aditya <14364734+AdityaSripal@users.noreply.github.com> --- spec/app/ics-020-fungible-token-transfer/README.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/spec/app/ics-020-fungible-token-transfer/README.md b/spec/app/ics-020-fungible-token-transfer/README.md index 60705a368..805e2b2db 100644 --- a/spec/app/ics-020-fungible-token-transfer/README.md +++ b/spec/app/ics-020-fungible-token-transfer/README.md @@ -279,7 +279,6 @@ function onSendFungibleTokens( transferVersion = payload.version if transferVersion == "ics20-1" { abortTransactionUnless(len(appData.tokens) == 1) - token = appData.tokens[0] // abort if forwarding defined abortTransactionUnless(appData.forwarding == nil) } else if transferVersion == "ics20-2" { @@ -300,7 +299,7 @@ Note: Function `parseICS20V1Denom` is a helper function that will take the full function onRecvPacket( destChannelId: bytes, sourceChannelId: bytes, - sequence: bigEndianUint64, + sequence: uint64, payload: Payload, ): (bytes, bool) { transferVersion = payload.version @@ -310,7 +309,7 @@ function onRecvPacket( var finalReceiver string // final intended address in forwarding case if transferVersion == "ics20-1" { - FungibleTokenPacketData data = payload.encoding.unmarshal(payload.appData) + FungibleTokenPacketData data = unmarshal(payload.encoding, payload.version, payload.appData) // convert full denom string to denom struct with base denom and trace denom = parseICS20V1Denom(data.denom) token = Token{