Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit: no 'unfillable' warning when revoke approval for permittable token #5295

Open
elena-zh opened this issue Jan 15, 2025 · 0 comments
Open
Labels
Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@elena-zh
Copy link

  1. Place a limit order with a permittable token (with a permit hook inside)
  2. While the order is being executed, place a market order with the same token (and permit hook inside)
  3. When the market order is executed, go to the revoke.cash app
  4. Revoke the token's approval
  5. Go to the limit orders page and check previously placed limit orders

AR: there is no 'unfillable' warning
image

ER: the warning should be present

@elena-zh elena-zh added Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Development

No branches or pull requests

1 participant