Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stopped_as_optional tests constraints satisfaction of self instead of child #311

Open
ericniebler opened this issue Jan 14, 2025 · 0 comments
Labels
bug Something isn't working P0

Comments

@ericniebler
Copy link
Collaborator

ericniebler commented Jan 14, 2025

[exec.stopped.opt]/para 3 reads:

  1. Let sndr and env be subexpressions such that Sndr is decltype((sndr)) and Env is decltype((env)). If sender-for<Sndr, stopped_as_optional_t> is false, or if the type single-sender-value-type<Sndr, Env> is ill-formed or void, then the expression stopped_as_optional.transform_sender(sndr, env) is ill-formed; otherwise, it is equivalent to:

the test for single-sender-value-type<Sndr, Env> is incorrect. it should be testing its child for single-sender-ness.

In addition, it should be applying FWD-ENV-T to Env so that only forwarding queries are forwarded.

Proposed resolution

Change single-sender-value-type<Sndr, Env> to single-sender-value-type<child-type<Sndr>, FWD-ENV-T(Env)> in [exec.stopped.opt] para 2 (twice!), where FWD-ENV-T is specified as in #313.

@ericniebler ericniebler added bug Something isn't working P0 labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0
Projects
None yet
Development

No branches or pull requests

1 participant