Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventsModules: Only call modules & functions that exist #26

Closed
cpursley opened this issue Dec 29, 2023 · 2 comments · Fixed by #40
Closed

EventsModules: Only call modules & functions that exist #26

cpursley opened this issue Dec 29, 2023 · 2 comments · Fixed by #40
Assignees
@cpursley
Labels
enhancement New feature or request

Comments

@cpursley
Copy link
Owner

Evn flag to disable calling assumed modules:

https://github.com/cpursley/walex/blob/master/lib/walex/events.ex#L28
@cpursley cpursley self-assigned this Dec 29, 2023
@cpursley cpursley added the enhancement New feature or request label Dec 29, 2023
@cpursley
Copy link
Owner Author

cpursley commented Jan 4, 2024

Maybe also consider DynamicSupervisor for Events in situation where modules aren't used (as sometimes just EventRelay and/or webhooks used without modules).

@cpursley cpursley linked a pull request Jan 4, 2024 that will close this issue
Destinations: Supervise and run only if configured. #33
Merged
@cpursley
Copy link
Owner Author

cpursley commented Jan 4, 2024

Actually, just cache which modules exist at compile time and only call those.

@cpursley cpursley removed a link to a pull request Jan 5, 2024
Destinations: Supervise and run only if configured. #33
Merged
@cpursley cpursley changed the title Flag to disable module calling EventsModules: Only call modules & functions that exist Jan 5, 2024
@cpursley cpursley linked a pull request Jan 7, 2024 that will close this issue
Config: Move modules under destinations. #40
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpursley cpursley

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Config: Move modules under destinations. cpursley/walex
1 participant
@cpursley