Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base URL is overwritten on bucket input blur #96

Open
timkelty opened this issue Aug 24, 2020 · 2 comments
Open

Base URL is overwritten on bucket input blur #96

timkelty opened this issue Aug 24, 2020 · 2 comments
Labels

Comments

@timkelty
Copy link
Contributor

timkelty commented Aug 24, 2020

It tries to infer the base url, but it should really only do this if that field is empty.

Screencast:
https://drive.google.com/file/d/10Te4cS53NojIQDyXEKO1i36nhNR_wS8d/view

@timkelty timkelty added the bug label Aug 24, 2020
@beporter
Copy link

beporter commented Oct 8, 2020

As a corollary to this, if the bucket name is set to an environment variable, say $S3_BUCKET_NAME, then the auto-generated Base URL gets written as https://s3.[region].amazonaws.com/$S3_BUCKET_NAME/ and used as a literal string without the bucket name being interpolated into the Base URL. This causes requests such as this to appear in the browser:

GET https://s3.us-east-2.amazonaws/$S3_BUCKET_NAME/assets/images/globals/logo.png

...which clearly won't work. 😞

@ccchapman
Copy link

This is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants