Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON schema missing unlimited option for --keep-* flags in the retention and forget profile sections #449

Open
asleeponpluto opened this issue Jan 5, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@asleeponpluto
Copy link

asleeponpluto commented Jan 5, 2025

Both the v1 and v2 JSON schemas are missing the unlimited option for --keep-* flags in the retention and forget profile sections. These options are currently set to "type": "integer" and, instead, should be:

{
    "type": ["integer", "string"]
    "oneOf": [
        {
            "type": "integer"
        }, 
        {
            "type": "string",
            "enum": ["unlimited"]
        }
    ]
}

I think anyOf is fine here too, not totally sure on which is preferred in this case as I have never used JSON schema.

@creativeprojects
Copy link
Owner

that was definitely missed, thanks for the report 👍🏻

@creativeprojects creativeprojects added the bug Something isn't working label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants