Skip to content
This repository has been archived by the owner on Feb 28, 2020. It is now read-only.

MessageTree.scala walk directions reversed #97

Open
mhluska opened this issue Aug 26, 2016 · 0 comments
Open

MessageTree.scala walk directions reversed #97

mhluska opened this issue Aug 26, 2016 · 0 comments

Comments

@mhluska
Copy link

mhluska commented Aug 26, 2016

See here @crockpotveggies .

We have:

case Right => this.left
case Left => this.right

Shouldn't it actually be:

 case Left => this.left
 case Right => this.right

Also, a couple things are broken:

  • I'm having issues with the match's name. In FunMessages.scala it ends up as a blank string. I can submit a PR
  • The runLengthConcat function in MessageUtil.scala seems to be broken. It concatenates all messages into one, not just repeated ones. Then there is only one sentiment and the matches get endlessly repeating messages from me

Also, it would be cool to link to a guide on obtaining the Facebook oauth token. I had to use a proxy since copy/pasting the URL doesn't work anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant