Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Projects #77

Closed
jameslaneconkling opened this issue May 25, 2015 · 3 comments
Closed

Social Projects #77

jameslaneconkling opened this issue May 25, 2015 · 3 comments
Assignees
Milestone

Comments

@jameslaneconkling
Copy link
Member

Add year field.

Reorder the fields in the input form according to the order in the spreadsheet documentation.

@markmcdonald51
Copy link
Contributor

done

@jameslaneconkling
Copy link
Member Author

@markmcdonald51 Unless they haven't been deployed yet, still not seeing the necessary changes:

  • needs year
  • should not have a company field. (company is of course the company whose being edited)
  • should not have option to 'Add Existing'

As for reordering the fields, I've assigned this to @charleshuang80 on the site translation ticket #70 . @markmcdonald51 can you make sure he knows both how to translate the labels, and reorder the fields (CC have been giving me a lot of flack about the ordering of fields).

@markmcdonald51
Copy link
Contributor

Hi James,
I am going to add in a year field but from your doc I dont see this field as a requirement, thus it wasn't added.

see: https://docs.google.com/spreadsheets/d/1FhdHEGWVYgImtm10Hj5B35F2WvQs5GyZWaD52zrClgk/edit#gid=1613944963
added migration to add year to social projects table
removed option to 'Add Existing'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants