Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Automated Rules view for evaluating matchExpressions and indicating matched targets #376

Open
2 of 3 tasks
Tracked by #325 ...
andrewazores opened this issue Feb 17, 2022 · 6 comments
Open
2 of 3 tasks
Tracked by #325 ...

Comments

@andrewazores
Copy link
Member

andrewazores commented Feb 17, 2022

@andrewazores
Copy link
Member Author

Conceptually, something like the OpenShift Console developer topology view. The application graph nodes would highlight in different colours or otherwise indicate whether they match the entered matchExpression. Pushing to 2.2.0.

@andrewazores andrewazores moved this to Pushed to Next Release in 2.1.0 Release May 13, 2022
@andrewazores andrewazores moved this to Todo in 2.2.0 Release May 13, 2022
@andrewazores andrewazores moved this from Todo to Stretch Goals in 2.2.0 Release May 17, 2022
@andrewazores andrewazores changed the title Automated Rules view for evaluating matchExpressions and indicating matched targets [Story] Automated Rules view for evaluating matchExpressions and indicating matched targets May 17, 2022
@andrewazores andrewazores added feat New feature or request and removed enhancement labels Jun 6, 2022
@andrewazores andrewazores moved this to Stretch Goals in 2.3.0 release Nov 3, 2022
@andrewazores
Copy link
Member Author

Pushed to 2.3.0.

@andrewazores andrewazores moved this from Stretch Goals to Todo in 2.3.0 release Dec 16, 2022
@tthvo
Copy link
Member

tthvo commented Feb 28, 2023

@andrewazores just came across this. How is this idea fitting the current topology view in #891?

@andrewazores
Copy link
Member Author

andrewazores commented Feb 28, 2023

I think this will probably get pushed back again, to 2.4.0 .

Basically, if there is some visualization of the discovered targets, then there should also be a way to display that visualization that somehow highlights or filters targets by ones that are matched by a given matchExpression. In a Topology view that could look like highlighting the matches or fading out the non-matches. In a list view that could be reordering the elements so that all the matches are at the top, and all the non-matches are at the bottom and faded/disabled.

With that, it should then be possible to update this visualization dynamically as the given matchExpression changes. So if I have a blank matchExpression then every target is faded. If I type true, every target is highlighted.

This would be used in views like the Automated Rules or Stored Credentials creation forms, to help users to tailor a matchExpression to the subset of targets that make sense for their usecase. There could be an additional section in the UI that contains this target visualization and dynamically updates as the expression is modified.

Specifically for the Topology view that you are working on, I think some minimized version of that topology graph could be the visualization I'm describing above. The minimized version would not need to be interactable at all - no way to add new targets, no way to view full resources details for a target, etc. Just simply the discovery view rendering as a visual aid component and the only additional details for a target being the ones that can be matched by the expression, ie the alias, connection URL, annotations/labels, and JVM hash ID.

@tthvo tthvo self-assigned this Mar 3, 2023
@tthvo tthvo moved this from Todo to In Progress in 2.3.0 release Mar 7, 2023
@tthvo
Copy link
Member

tthvo commented Mar 16, 2023

Just a question about template select in Rule create form here: Looks like we are fetching templates for the selected target. But when moving to a "topology graph view" of the target, users will be seeing many target of the same time. Should we get the common templates among targets the match expression matches?

Screenshot from 2023-03-16 14-54-48

@andrewazores
Copy link
Member Author

That sounds like it makes sense, just do a set intersection.

@tthvo tthvo moved this from In Progress to Pushed to 2.4.0 in 2.3.0 release Apr 11, 2023
@tthvo tthvo removed their assignment Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Pushed to Next Release
Status: Stretch Goals
Status: Pushed to 2.4.0
Development

No branches or pull requests

2 participants