Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): fix TLS enforcement for Agent instances #758

Merged

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Dec 23, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #747
See also #776

Description of the change:

Corrects a logical error in the Agent TLS connection enforcement.

How to manually test:

  1. Check out and build PR
  2. ./smoktest.bash -O -t quarkus-cryostat-agent
  3. Ensure that all the usual tasks complete successfully when selecting the Agent HTTPS target

@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 12/23/2024, 2:34:50 PM. View Actions Run.

Copy link

No GraphQL schema changes detected.

Copy link

No OpenAPI schema changes detected.

Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/12472012840

@andrewazores andrewazores force-pushed the agent-non-tls-connections branch from 3652784 to 4678a6e Compare January 15, 2025 22:26
@andrewazores andrewazores requested a review from ebaron January 15, 2025 22:26
@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 1/15/2025, 5:26:45 PM. View Actions Run.

Copy link

No OpenAPI schema changes detected.

Copy link

No GraphQL schema changes detected.

Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/12798124358

@andrewazores andrewazores merged commit 48eacd0 into cryostatio:main Jan 16, 2025
12 checks passed
@andrewazores andrewazores deleted the agent-non-tls-connections branch January 16, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants