Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Governance page #221

Merged
merged 41 commits into from
Dec 8, 2023
Merged

Update Governance page #221

merged 41 commits into from
Dec 8, 2023

Conversation

JustinBeBoy
Copy link
Collaborator

@JustinBeBoy JustinBeBoy commented Oct 30, 2023 •
edited
Loading

This PR resolve #181

  • Update Governance page
  • Update proposal page
  • Update logic search proposal
  • Fix scroll view load proposal
  • Update logic save proposal
  • Update proposal detail page
  • Update Consensus changes page
  • Update Treasury spending page
  • Clean code

Screenshot

image
image
image
image

@JustinBeBoy JustinBeBoy marked this pull request as ready for review November 1, 2023 14:43
@JustinBeBoy JustinBeBoy changed the title Government Update Government page Nov 1, 2023
@JustinBeBoy JustinBeBoy changed the title Update Government page Update Governance page Nov 1, 2023
@dreacot
Copy link
Member

dreacot commented Nov 1, 2023

This PR
image

figma
image

@dreacot dreacot marked this pull request as draft November 4, 2023 17:21
@JustinBeBoy JustinBeBoy marked this pull request as ready for review November 9, 2023 07:50
dreacot
dreacot reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. this needs to be a dropdown

Screenshot from 2023-11-13 12-51-44

  1. voting preference is abstain by default for decred wallet

Screenshot from 2023-11-10 11-56-06

  1. newest/oldest don't do anything
    Screenshot from 2023-11-10 11-57-20

Sirmorrison
Sirmorrison suggested changes Nov 27, 2023
View reviewed changes
ui/page/governance/consensus_page.go Outdated Show resolved Hide resolved
itswisdomagain
itswisdomagain previously requested changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@itswisdomagain itswisdomagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass.

libwallet/internal/politeia/politeia.go Outdated Show resolved Hide resolved
libwallet/internal/politeia/politeia.go Outdated Show resolved Hide resolved
libwallet/internal/politeia/politeia_sync.go Outdated Show resolved Hide resolved
libwallet/internal/politeia/politeia.go Outdated Show resolved Hide resolved
libwallet/internal/politeia/types.go Outdated Show resolved Hide resolved
ui/cryptomaterial/editor.go Outdated Show resolved Hide resolved
ui/cryptomaterial/editor.go Outdated Show resolved Hide resolved
ui/cryptomaterial/editor.go Outdated Show resolved Hide resolved
ui/cryptomaterial/editor.go Outdated Show resolved Hide resolved
ui/cryptomaterial/editor.go Outdated Show resolved Hide resolved
@dreacot
Copy link
Member

dreacot commented Dec 6, 2023

I have changed how to save proposal on db, so if you want to search please clear proposals data before test

how can we do this?

previously disabling proposals fetching cleared the db, but that's not the case anymore

@JustinBeBoy

@dreacot
Copy link
Member

dreacot commented Dec 6, 2023

About dropdown for order, status and wallet selector need to update on other PR

dex PR and transactions page PR has been merged, please look at updating the dropdown for this PR

@JustinBeBoy
Copy link
Collaborator Author

I have changed how to save proposal on db, so if you want to search please clear proposals data before test

how can we do this?
previously disabling proposals fetching cleared the db, but that's not the case anymore

@JustinBeBoy

we don't need to do it, I have update logic search on proposal and remove new field on db

@dreacot
Copy link
Member

dreacot commented Dec 6, 2023

update the dropdown on the proposal details page

Screenshot from 2023-12-06 10-32-44

clicking the dropdown on the treasury page is distorted

Screenshot from 2023-12-06 10-33-25

if a dcr wallet is available it should be the first selected wallet by default

Screenshot from 2023-12-06 10-34-29

dcr dex page has the dropdow style you should be using

Screenshot from 2023-12-06 10-35-45

this is what figma has

Screenshot from 2023-12-06 10-36-07

@dreacot
Copy link
Member

dreacot commented Dec 6, 2023

doesn't look like figma specifications are fully being followed to me

@JustinBeBoy
Copy link
Collaborator Author

doesn't look like figma specifications are fully being followed to me

I have fixed it, thanks

@dreacot
Copy link
Member

dreacot commented Dec 8, 2023

doesn't look like figma specifications are fully being followed to me

I have fixed it, thanks

Screenshot from 2023-12-07 20-18-45

this should be a dropdown

@JustinBeBoy
Copy link
Collaborator Author

doesn't look like figma specifications are fully being followed to me

I have fixed it, thanks

Screenshot from 2023-12-07 20-18-45

this should be a dropdown

done

@dreacot dreacot merged commit 819d0fd into crypto-power:master Dec 8, 2023
1 check passed
@JustinBeBoy JustinBeBoy deleted the government branch March 15, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sirmorrison Sirmorrison Sirmorrison requested changes

@itswisdomagain itswisdomagain itswisdomagain left review comments

@dreacot dreacot dreacot approved these changes

@ukane-philemon ukane-philemon Awaiting requested review from ukane-philemon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Governance] design new layout for the governance page
5 participants
@JustinBeBoy @dreacot @ukane-philemon @itswisdomagain @Sirmorrison