Reconciliaton API - iteration 3 multi-language

[saumier]

See doc https://docs.google.com/document/d/10eiOqials4PDipSw3zhNYTw_UbE0W0SuUk7nIAbMHxM/edit#heading=h.qbm5wo48afoq

Test on Culture Creates github page:
https://culturecreates.github.io/testbench/#/client/https%3A%2F%2F35.183.160.6%2Freconcile

Tasks

• modify Reconciliation REACT test bench as per screen design in doc
• update server to use draft spec on reconciliation service with languages for every literal in the query
• reconcile with additional properties that are URIs
• reconcile with additional properties that are literals
• Reconcile events with dates
• Reconcile with external entity URI only (without needing to send a name)

[AbhishekPAnil]

Here is the swagger link for artsdata testing with the latest draft version :
https://35.183.160.6/api#/APIs/ReconciliationController_reconcileByQuery

[saumier]

@sahalali The test bench is getting an error. I think this needs to be fixed on the reconciliation server.

@AbhishekPAnil Please deploy to culturecreates github pages so it is easier to test. You can deploy to ghpages using >npm run build and then >npm run deploy but just make sure you are in culturecreates and not the official W3C repo.

[AbhishekPAnil]

@saumier The branch culturecreates:enhancement/issue-13 for test bench has been deployed.
You can test it here : https://culturecreates.github.io/testbench/

[saumier]

@sahalali @AbhishekPAnil The endpoint error I experienced above is probably because we don't have an SSL certificate on the server, and you both have probably accepted the insecure connection in your browser. However, we should have an SSL certificate if we want others in the W3C reconciliation group to play around and expore the new endpoint. @sahalali Can you please add an SSL certificate?

Also, @sahalali Do you have an idea why the test bench is showing "Validations error for reconcilation response
undefined must be object"

[saumier]

@AbhishekPAnil I'll open an issue in our culturecreates testbench repo and ask you to merge your work in to our main branch. culturecreates/testbench#4

[sahalali]

Please review this.

[saumier]

@sahalali The Reconciliation test bench at culturecreates is not working with this endpoint
https://culturecreates.github.io/testbench/#/client/https%3A%2F%2F35.183.160.6%2Freconcile

[saumier]

@sahalali After you restarted the database the reconciliation service worked for a little while but then stopped again before I could make the demo. I only did a couple requests so I don't think there was any stress put on the server.

Please investigate as to why the server seems to stop working.

[sahalali]

The graph db server looks stable now. Still I will keep an eye on it for few more days.

[saumier]

@sahalali The Reconciliation test bench at culturecreates is not working with this endpoint
https://culturecreates.github.io/testbench/#/client/https%3A%2F%2F35.183.160.6%2Freconcile

I don't think the graphdb is down, but there is a problem connecting the test bench to the API. Maybe something simple like a missing SSL. Please check it out.

[saumier]

@sahalali I am having a couple of issues:

1. When I query "Reconcile against no particular type" with anything (i.e. "place des arts") the service hangs with "Querying the service..." in what appears to be an endless loop.
2. When a query takes a long time there should be a safeguard to timeout after about 30 seconds. I think there is a GraphDB config that you can check first.
3. There is an error in the test bench when calling the new reconciliation service v1.0-draft. This should be looked at with Abhishek

Validations error for reconcilation response
undefined must be object

[sahalali]

1. The issue with the endless loop was due to a problem in the SPARQL query, which has been fixed and deployed.
2. The query timeout has been set to 60 seconds, ensuring that query execution will be automatically aborted after this time. @saumier, please let me know if you think we should adjust this value. This setting applies at the repository level.
3. @AbhishekPAnil Can you take a look?

[AbhishekPAnil]

My findings:

1. We need to change the version number from v1.0-draft to 1.0-draft.The manifest stores the enum as 1.0-draft.You can also check the spec repository or the manifest for verification.

2.The suggest key inside the 1.0-draft manifest has some required properties.
Right now the existing values for suggest is

"suggest": {
       "type": {
           "service_path": "/en/suggest/type",
           "service_url": "https://wikidata.reconci.link"
       }
   }

I think this was with respect to the 0.2 version.This should be replaced with ,for eg :

"suggest": {
    "entity": false,
    "property": true,
    "type": false
  }

Please refer this section for the change.

3.Also ,in our test bench the Support for multi-lingual candidate names(Ref this issue) was added.
The support for multi-lingual candidate names is not yet added in the schema for 1.0-draft.Refer this issue.I can see the changes with the PR is raised in the spec repo.

[saumier]

@AbhishekPAnil Thanks for documenting your findings here.

I also created a time sheet code for work related to W3C called: W3C CG Open Source Contribution. Please use this project code going forward. I will take care of the past timesheets. Thx.

[saumier]

My findings:

1. We need to change the version number from v1.0-draft to 1.0-draft.The manifest stores the enum as 1.0-draft.You can also check the spec repository or the manifest for verification.

@sahalali Please update the version number in the Reconciliation service manifest as per Abhishek's finding above. Thx.

2. The suggest key inside the 1.0-draft manifest has some required properties.

@sahalali I don't think there is a suggest service implemented in the new Artsdata Reconciliation service 1.0-draft. In the old Artsdata reconciliation service 0.2 I did not implement a suggest service but borrowed the one from Wikidata. For our new service we should either implement a suggest service or remove it from the manifest. If you are unsure about this service then I propose removing it from the manifest.

[sahalali]

For now I removed suggest from the manifest and updated version number.

[saumier]

@sahalali This iteration 3 ran into a blocker because of a design debate in the W3C group. There is now alignment on the path forward. We should re-implement our User Story Reconcile a Place in any language. To do this we need to change the implementation of the Reconciliation server (still version 1.0-draft) and the Reconciliation Test Bench to match the updated specs. I am meeting with the W3C group tomorrow and following that meeting I will summarize the changes back here.