Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap upgrade & Glyphicon replace #11

Open
renlinch opened this issue Jul 13, 2018 · 6 comments
Open

Bootstrap upgrade & Glyphicon replace #11

renlinch opened this issue Jul 13, 2018 · 6 comments

Comments

@renlinch
Copy link
Contributor

I would Prefer to upgrade to Bootstrap 4.x and change from Glyphicon to open-cionic.

Before i start the work to do that is it ok ?

@dantti
Copy link
Member

dantti commented Jul 13, 2018

The only issue I have with BS4 is that it requires newer Browsers, not sure about what is the minimum but maybe have a new separated BS4 theme, that becomes the default one.

@renlinch
Copy link
Contributor Author

Ok i did look at it, but i think supported browser for v4 Bootstrap is ok. IE < 10 is only unsupported Operating Systems and EOL Browsers who should not be used anymore.

@renlinch
Copy link
Contributor Author

renlinch commented Aug 9, 2018

I was working on a new Webinterface and the first Alpha (There is a lot to do ....) is ready now ...

You could test it, in my Private branch: update-web

More Update will come 😄

@dantti
Copy link
Member

dantti commented Aug 9, 2018

Cool, I'm about to do a new release in the next weeks but I guess this won't be ready in time?

@renlinch
Copy link
Contributor Author

renlinch commented Aug 9, 2018

Maybe ... it's most small fixes ... Please have a look at it and say what could be better 😃

@dantti
Copy link
Member

dantti commented Jan 23, 2019

I had a look over your update, the only thing that I don't like much is carrying bootstrap files, I know it's not really an issue but I like a clean repo... can you do a few PR do merge that here, so that we can evolve that and not lose your work time?
We can provide an external URL to get BS and a config flag to use static path instead of CDNs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants