Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIgrate to react router to remove UI state from redux store #78

Open
danobot opened this issue Dec 1, 2020 · 0 comments
Open

MIgrate to react router to remove UI state from redux store #78

danobot opened this issue Dec 1, 2020 · 0 comments

Comments

@danobot
Copy link
Owner

danobot commented Dec 1, 2020

Much of the metadata info in the store should be moved to URL params.
Things like the selected note or filters applied to the note list.
This is a technical dept.

Data to move to query params:

  • filters on note list
  • global search queries

Move to path:

  • selected notebook
  • selected note

routes:

  • /notebook/1535/note/2433

Implementation steps:

  • Introduce Router component and routes at root level
  • Update actions that store UI state to instead modify the URL path and params
  • Update components that depend on this data to read it from path/params instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant