Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laundry list of feature requests #8

Open
kalepail opened this issue Apr 29, 2024 · 1 comment
Open

Laundry list of feature requests #8

kalepail opened this issue Apr 29, 2024 · 1 comment

Comments

@kalepail
Copy link

kalepail commented Apr 29, 2024

First off thank you so much for this package. It's been an absolute life saver for a recent project I've been working on https://github.com/kalepail/soroban-passkey (https://passkey.sorobanbyexample.org/)

As much as I love it though I'm shooting my shot on getting some additional features added to the iOS and Android plugins to bring this up to feature parity with the web version.

Namely:

  • Add security key support
  • Support the full range of APIs
  • Upgrade to Capacitor 6

Currently security keys work on the web but not on iOS or Android. So think things like NFC or USB Yubikey type devices.

So for example on iOS this would be ASAuthorizationSecurityKeyPublicKeyCredentialProvider. I'm no Swift or Java dev so I've just done some preliminary research to explore if this was possible, it seems to be, but it's not supported atm.

The other is that most keys aren't passed along or respected in the iOS integration. So things like authenticatorSelection and pubKeyCredParams aren't used in the startRegistration nor are the allowCredentials in the startAuthentication which means you can't specifically prefer a "signed in" key when signing something with a key that has previously startRegistration, it will just show the full list.

Definitely happy to help test all this stuff, I have an Android and iOS, a Mac, a PC, a basic and an NFC Yubikey, you name it I can probably get it, I would just love to see the feature set of this plugin fully built out.

Thanks again for the work on this, it's some really useful stuff 🙏

@kalepail
Copy link
Author

kalepail commented Apr 29, 2024

When tapping "Save on Another Device"

iOS Safari iOS native
IMG_3426 IMG_3427

(Android Chrome vs Android native is similar)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant