Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Dask " from the titles of tabs #201

Closed
mrocklin opened this issue Jul 20, 2021 · 5 comments · Fixed by #205
Closed

Remove "Dask " from the titles of tabs #201

mrocklin opened this issue Jul 20, 2021 · 5 comments · Fixed by #205

Comments

@mrocklin
Copy link
Member

My JLab panes look like this:

Screen Shot 2021-07-20 at 6 29 31 AM

If we removed the word Dask from all of the titles then it would be easier to see what was what. We already have the icon to distinguish these from other kinds of tabs.

@ian-r-rose
Copy link
Collaborator

Agreed, the icon should suffice.

A fairly simple fix, requires updating the labels here:

if (`Dask ${dashboard.label}` !== widget.title.label) {
widget.title.label = `Dask ${dashboard.label}`;
}

and here:

dashboard.title.label = `Dask ${dashboardItem.label}`;

@mrocklin
Copy link
Member Author

Should I interpret this last comment as "this is easy so I'll do it soon" or "this is easy so it might be a good opportunity to bring in some new". If the latter, Alex?

@ian-r-rose
Copy link
Collaborator

I'm happy to do it soon (it is indeed very easy), but I'm also happy to bring on any extra hands. I suppose I intended it as a flare to see if any interested contributors popped up.

@mrocklin
Copy link
Member Author

mrocklin commented Jul 20, 2021 via email

@GenevieveBuckley
Copy link
Contributor

silent masses, lol

Well, I came over here to complain about something (and find out that Ian has already fixed it, fantastic), so I may as well fix someone else's frustration while I'm here instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants