-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No visibility (black background) with JupyterLab in Dark theme #242
Comments
Thanks for the report @JonnyTran , there is some additional discussion here. I think the easiest fix would be to add a bit of explicit CSS to the background of the plot iframes. Would you be interested in submitting a PR? |
Sure! I'll take a look. If I have any questions I'll post it here or the orig issue. |
Great! I think the easiest approach would be to create a new CSS class for the iframes here, and then to add that CSS class to the iframe widgets in the constructor here: dask-labextension/src/dashboard.tsx Lines 52 to 62 in 707ecb1
There are other widgets in the same file that add CSS classes (using |
… even in JupyterLab Dark theme iframe widgets in the constructor to use new CSS class Issue: dask#242
What happened:
With JupyterLab in Dark theme, the Bokeh dashboards doesn't have a white background so drawings are not visible.
What you expected to happen:
Bokeh dashboards should have a white plot background.
Environment:
JupyterLab 3.4.7
dask-labextension (pip install)
The text was updated successfully, but these errors were encountered: