Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing # rubocop:enable comments, and fix any resulting style issues #23

Closed
ryscher opened this issue Jun 27, 2018 · 0 comments
Closed

Comments

@ryscher
Copy link
Member

ryscher commented Jun 27, 2018

(description copied from CDLUC3/stash#2 by @dmolesUC3)

When I first set up RuboCop, I assumed # rubocop:disable was block scoped, but it turns out it's meant to be paired with a matching # rubocop:enable. Without that, it means "disable till further notice".

We've put # rubocop:enable in a few places (e.g. Resource::duplicate_filenames), but there are still a lot of orphan disables out there. At some point we should clean these up, and fix any style issues we discover in code where checks were unintentionally disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants