Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset List] Modal dialogs don't display a close icon #29

Open
keithmoss opened this issue Jan 24, 2019 · 4 comments
Open

[Dataset List] Modal dialogs don't display a close icon #29

keithmoss opened this issue Jan 24, 2019 · 4 comments

Comments

@keithmoss
Copy link
Contributor

keithmoss commented Jan 24, 2019

https://uat.landgate.links.com.au/dataset

Responsive design issue on mobile devices.

For example, the "Filter results" modal dialog doesn't display any close icon in the top right hand corner. There's still a UI element there and you can click it, just no icon to show that there's something to click.

Suggestion: Change the <i class="icon-remove-sign"> icon class to <i class="fa fa-times-circle">.

There may be other modals that suffer the same issue - so worth a find/replace for "icon-remove-sign" across the whole code base.

UAT
screen shot 2019-01-24 at 12 36 02

PROD
screen shot 2019-01-24 at 12 35 58

@krupalip
Copy link
Contributor

krupalip commented Feb 13, 2019

Hi @keithmoss , I couldn't see orgs on dataset page.
image

@keithamoss
Copy link
Contributor

It wasn't organisations specifically, but more the contents of the whole filter sidebar. Also it was a responsive design issue - so you'll have to use your browser's dev tools to see it.

Here's a GIF demonstrating:

uat-ckan-responsive-dialog-no-close-button

@krupalip
Copy link
Contributor

krupalip commented Feb 14, 2019

oh I see. I will have look. Thanks

@krupalip
Copy link
Contributor

fixed.
it was font awesome icon name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants