Replies: 1 comment
-
@waedi thank you for your question.
You're right, they should be optional like the core library ( |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Summary
When I try to pass options to emblaCarouselSvelte as shown in the docs here (Svelte Tab), I get the error
Property 'plugins' is missing in type '{ options: Partial<OptionsType>; }' but required in type 'EmblaCarouselParameterType'
:This is how it should be done according to the docs:
<div class="embla" use:emblaCarouselSvelte={{ options }} onemblaInit={onInit}>
Of course this works, but is inconsistent with the documentation:
<div class="embla" use:emblaCarouselSvelte={{ options, plugins: [] }} onemblaInit={onInit}>
Wouldn't it make sense to make the properties optional in packages/embla-carousel-svelte/src/components/emblaCarouselSvelte.ts like so:
type EmblaCarouselParameterType = { options?: EmblaOptionsType plugins?: EmblaPluginType[] }
If applicable, which variants of Embla Carousel are relevant to this conversation?
Additional information
No response
CodeSandbox example
No response
Beta Was this translation helpful? Give feedback.
All reactions