Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pwa: no sanitization of options for the manifest creation #54

Closed
davidsneighbour opened this issue Jul 14, 2022 · 1 comment
Closed

pwa: no sanitization of options for the manifest creation #54

davidsneighbour opened this issue Jul 14, 2022 · 1 comment
Assignees
@davidsneighbour
Labels
module:pwa type:enhancement New enhancements and features.

Comments

@davidsneighbour
Copy link
Owner

currently everything in site.Params.dnb.pwa is printed into the manifest file. This should be filtered against a list of available options and sanitized.

see also #53
@davidsneighbour davidsneighbour self-assigned this Jul 14, 2022
@davidsneighbour davidsneighbour changed the title bug: no sanitization of options for the manifest creation hugo-pwa: no sanitization of options for the manifest creation Apr 3, 2023
@davidsneighbour davidsneighbour transferred this issue from davidsneighbour/hugo-pwa Apr 3, 2023
@davidsneighbour davidsneighbour added state:unconfirmed This issue needs to be reproduced. module:pwa labels Aug 4, 2024
@davidsneighbour davidsneighbour changed the title hugo-pwa: no sanitization of options for the manifest creation pwa: no sanitization of options for the manifest creation Aug 10, 2024
@davidsneighbour davidsneighbour added state:confirmed This issue is confirmed. type:enhancement New enhancements and features. and removed state:unconfirmed This issue needs to be reproduced. labels Aug 10, 2024
@davidsneighbour
Copy link
Owner Author

not required.

@github-actions github-actions bot removed the state:confirmed This issue is confirmed. label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidsneighbour davidsneighbour

Labels
module:pwa type:enhancement New enhancements and features.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidsneighbour