Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified 'exit' as 'sys.exit' in the code to improve cross platform compatibility #1185

Open
fcwys opened this issue Jan 6, 2025 · 4 comments

Comments

@fcwys
Copy link

fcwys commented Jan 6, 2025

Unified exit as sys. exit in the code to improve cross platform compatibility,due to the special working environment, it is not possible to install mycli using pip. When using pyinstaller to package as binary, the exit error in main.py is reported. After modifying it to sys. exit, it works normally. Test commands such as mycli.exe -uroot -proot -e "select version();"

@amjith
Copy link
Member

amjith commented Jan 7, 2025

No objections to this proposal. Could you send a PR with this change?

@fcwys fcwys changed the title Unified 'exit' as' sys. exit 'in the code to improve cross platform compatibility Unified 'exit' as 'sys.exit' in the code to improve cross platform compatibility Jan 7, 2025
@fcwys
Copy link
Author

fcwys commented Jan 7, 2025

#1187

@HossamSaberX
Copy link

Greetings!
May i know how did you manage to traverse the codebase to spot the issue's code lines?

@fcwys
Copy link
Author

fcwys commented Jan 8, 2025

I checked this manually because I used pyinstaller to package the binary run save and found problems in "main.py".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants