New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] `compiled_code` instead of `sql` within `default__get_limit_sql` macro #370

Closed

dbeatty10 opened this issue Dec 5, 2024 · 0 comments · Fixed by #372

Labels

type:bug

Contributor

dbeatty10 commented Dec 5, 2024 •

edited

Loading

Originally posted by @greghroberts in #249 (comment):

@VersusFacit and @mikealfare Looks like this line should be using the function parameter {{ sql }}. It works with {{ compiled_code }} I assume because of the context being set in the get_show_sql macro, but that's likely hiding a future bug.

I could be wrong, but ran into this when providing a custom version of get_show_sql in my project.

The text was updated successfully, but these errors were encountered:

dbeatty10 changed the title @VersusFacit and @mikealfare Looks like this line should be using the function parameter {{ sql }}. It works with {{ compiled_code }} I assume because of the [context being set in the get_show_sql macro](https://github.com/dbt-labs/dbt-core/blob/1d3d315249c81dbca70452e5a14fbfd0edad6b2a/core/dbt/task/show.py#L34), but that's likely hiding a future bug. [Bug] compiled_code instead of sql within default__get_limit_sql macro

dbeatty10 added type:bug triage:product labels

dbeatty10 mentioned this issue

Use sql instead of compiled_code within the default get_limit_sql macro #372

Merged

4 tasks

amychen1776 removed the triage:product label

VersusFacit closed this as completed in #372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment