Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the format unrelated yml, which shows up as a diff in git #114

Open
1 of 5 tasks
graciegoheen opened this issue Aug 16, 2023 · 0 comments
Open
1 of 5 tasks
Labels
bug Something isn't working

Comments

@graciegoheen
Copy link
Collaborator

Describe the bug

When running the contract commands (and maybe others), there is occasionally unrelated yml blocks that appear "changed" when looking at the git diff.

  • deleting whitespace
  • deleting comments
  • making multiline stuff one line

This requires someone to then manually go back through and revert these changes to the original yml.

dbt-meshify should not edit unrelated yml blocks.

Steps to reproduce

  • use dbt-meshify to add a contract to a model with a pre-existing column description that has multiple lines

Expected results

  • the description should remain untouched

Actual results

  • you will see the multi-line description is changed to 1 line

Screenshots and log output

System information

Which database are you using dbt with?

  • postgres
  • redshift
  • bigquery
  • snowflake
  • other (specify: ____________)

The output of dbt debug:

<output goes here>

The output of dbt --version:

<output goes here>

Additional context

Are you interested in contributing the fix?

@graciegoheen graciegoheen added bug Something isn't working triage Tis issue or pull request must be triaged by a project maintainer labels Aug 16, 2023
@nicholasyager nicholasyager removed the triage Tis issue or pull request must be triaged by a project maintainer label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants