Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle on_schema_change for incrementals with contracts #50

Open
dave-connors-3 opened this issue May 30, 2023 · 1 comment
Open

handle on_schema_change for incrementals with contracts #50

dave-connors-3 opened this issue May 30, 2023 · 1 comment

Comments

@dave-connors-3
Copy link
Collaborator

Incremental models with contracts must have the on_schema_change config set to append_new_columns. This will need to be a conditional piece of logic in the add-contract command.

Options

  1. add it to the model yml entry blindly
  2. be more creative and find where the config is set from and override apropriately.

1 feels good short ter, 2 feels right long term!

@b-per
Copy link
Contributor

b-per commented Jun 8, 2023

Not entirely related to meshify but this is an interesting statement about contracts + schema evolution.

Based on what you observed, if a contracted incremental model has 4 columns, a, b, c, d and if at some point one column is dropped, the model will run fine until we do a --full-refresh which will then make it fail.

This is going to create a few headaches when going through CI/CD, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants