Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove hack to scrub inCommitTimestamp from commitInfo schema on write path #634

Open
OussamaSaoudi-db opened this issue Jan 9, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@OussamaSaoudi-db
Copy link
Collaborator

Please describe why this is necessary.

The write path currently does not support writing in-commit timestamps. Currently, we manually remove the inCommitTimestamp field from the CommitInfo schema to avoid writing null for that field. Moreover we remove the field regardless of whether ICT is enabled or not on the table.

Describe the functionality you are proposing.

Come up with a way to modify commitInfo schema based on whether inCommitTimestamp is enabled on the table. If ICT is enabled, then the schema should include it.

Additional context

This should ideally be a generalized way to update the schema for things like operationParameters and engineCommitInfo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant