Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Snapshot should not expose delta implementation details #648

Open
OussamaSaoudi opened this issue Jan 17, 2025 · 0 comments
Open
Labels
breaking-change Change that will require a version bump good first issue Good for newcomers

Comments

@OussamaSaoudi
Copy link
Collaborator

OussamaSaoudi commented Jan 17, 2025

Currently, the Snapshot struct has pub methods to access protocol, metadata, and column_mapping_mode. These methods are Delta implementation details that are best not exposed to the user. A Snapshot user should only be interested in the version and the schema. On the other hand, consumers of kernel may need to know more things about the table such as table configuration. Thus we need a way to make these internal details public. Kernel allows this through the developer-visibility feature flag.

Remove the methods protocol, metadata, and column_mapping methods from Snapshot. Change all callers so that they use table_configuration() instead.

@OussamaSaoudi OussamaSaoudi added the good first issue Good for newcomers label Jan 17, 2025
@OussamaSaoudi OussamaSaoudi changed the title refactor: Snapshot should not expose delta implementation details refactor!: Snapshot should not expose delta implementation details Jan 17, 2025
@OussamaSaoudi OussamaSaoudi added the breaking-change Change that will require a version bump label Jan 17, 2025
@OussamaSaoudi OussamaSaoudi changed the title refactor!: Snapshot should not expose delta implementation details refactor!: Make TableConfiguration the point of validation and querying for metadata and protocol Jan 17, 2025
@OussamaSaoudi OussamaSaoudi changed the title refactor!: Make TableConfiguration the point of validation and querying for metadata and protocol refactor!: Snapshot should not expose delta implementation details Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Change that will require a version bump good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant